Re: [xml-bindings]incorect PyFile_Get macro

[Daniel Veillard <veillard redhat com>]

On Tue, Sep 17, 2002 at 09:13:48PM +0200, mattam netcourrier com wrote:
> Hi!
> 
> 	I tried to dump a doc using xmlDoc.dump, but it didn't work
> 	(i'm working with libxml2-2.4.23). I traced the problem to an
> 	incorrect macro definition in libxml_wrap.h.
> 
> 	#define PyFile_Get(v) (((v) == Py_None) ? NULL : \
> 		(PyFile_Check(v) ? NULL : (PyFile_AsFile(v))))
> 	
> 	is better defined as
> 	#define PyFile_Get(v) (((v) == Py_None) ? NULL : \
> 		(PyFile_Check(v) ? (PyFile_AsFile(v)) : NULL))
> 		
> 	isn't it?


  Dohhhh !!!!!

    thanks ! Applied and commited :-)

Daniel

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/