Re: [Vala] testrunner.sh on OpenIndiana

[Al Thomas <astavale yahoo co uk>]

> On Wednesday, 1 November 2017, 19:48:37 GMT, Jason Martin <agrellum gmail com> wrote: 

> All but three pass now. My patch below. Comments might help someone.

> ERROR:/export/home/agrellum/vala-0.36.6/tests/_test/main.c:111:control_flow_bug736774_2_main:
> assertion failed: (keep != "test")

That's disturbing! It would be good to get to the root cause of this one, although it probably doesn't relate 
to the testrunner.

> /dbus/enum-string-marshalling
> main.vala:17.42-17.57: error: The type name `UnixOutputStream' could not be
> found

This needs --pkg gio-unix-2.0, but I can't figure out how the current build system passes that in VALAFLAGS.

> /dbus/filedescriptor-errors/server
> Conversion from character set '646' to 'UTF-8' is not supported

Not sure this is Vala related.

> Patch:
I've tried to apply the patch, but mail systems often remove the leading spaces. I've added them back after 
copy and pasting, but that patch still doesn't apply. I used:
patch testrunner.sh copied-from-mail.patch
I get:
patch: **** malformed patch at line 16: @@ -114,26 +119,32 @@

It would be better now to open an "Improve testrunner.sh portability" bug at bugzilla with a git formatted 
patch.

+# OpenIndiana add -v flag for extra logging
Seems like a good idea.

+# Hardcoded --cc flag for now; Use ./configure CC=gcc when building vala
+# System can have many CC's and gcc may not be default
+# Remove -X -Werror=int-conversion; Not an option with gcc (GCC) 4.9.4
OpenIndiana build

Maybe the flags should be split over multiple lines, with a tab indent. e.g.
+VALAFLAGS="$VALAFLAGS \
    -v \
    --cc=gcc \
    --vapidir $vapidir \
    --disable-warnings"

Given the age of the GCC4 series I'm inclined to say OpenIndiana should carry an out of tree patch removing 
the int-conversion option. By splitting the flags over multiple lines it would make that patch easier to read.

Also OpenIndiana may move to GCC5 at some point:
https://www.openindiana.org/2017/04/23/gcc-6-and-the-status-of-compilers-in-openindiana/

If no --cc option is given and CC is not set then Vala uses cc. See:
https://git.gnome.org/browse/vala/tree/codegen/valaccodecompiler.vala

Thanks,

Al