Re: [Vala] realloc fails on large inputs

[Nor Jaidi Tuah <norjaidi tuah ubd edu bn>]

> Thank you, now it does not crash anymore on calculating the factorial
> :)
> Nonetheless size - 1 should equal to old_length. Because I call the
> function using old_length + 1 so the new size should equal to the
> old
> one - 1. Anyway, now it works :)

new size is not necessarily old_length+1, unless
n happens to have the same number of digits as self.

Furthermore, your add function:

        fill(_data.length + 1);
        n.fill(_data.length);

should have been:

        newSize = int.max(_data.length, n._data.length) + 1
        fill(newSize)
        n.fill(newSize)

Otherwise, the following won't work:

        x = new Number(1)
        y = new Number(11111111)
        x.add(y)    <--- only room for 2-digit result


> Unfortunately the error with the double free or corruption still
> exists.

The to_string function should put a null terminator.

Nice day
Nor Jaidi Tuah



PRIVILEGED/CONFIDENTIAL information may be contained in this message. If you are neither the addressee 
(intended recipient) nor an authorised recipient of the addressee, and have received this message in error, 
please destroy this message (including attachments) and notify the sender immediately. STRICT PROHIBITION: 
This message, whether in part or in whole, should not be reviewed, retained, copied, reused, disclosed, 
distributed or used for any purpose whatsoever. Such unauthorised use may be unlawful and may contain 
material protected by the Official Secrets Act (Cap 153) of the Laws of Brunei Darussalam. DISCLAIMER: 
We/This Department/The Government of Brunei Darussalam, accept[s] no responsibility for loss or damage 
arising from the use of this message in any manner whatsoever. Our messages are checked for viruses but we do 
not accept liability for any viruses which may be transmitted in or with this message.