Re: [Vala] [PATCH] add missing XStringToKeysym() function to x11.vapi



Am Mittwoch, den 30.03.2011, 21:43 +0200 schrieb Luca Bruno:
I'd rather put that static function outside Display, what do you think?

IMHO XStringToKeysym() is somewhat similar to XKeysymToKeycode() which
(of course) is inside Display. Consider this example code:

        Display display = new X.Display();
        int keysym = display.string_to_keysym(keystr);
        int keycode = display.keysym_to_keycode(keysym);

So, in total I would consider it more intuitive if all these XFooToBar()
functions would be in the same place (I plan to also submit a patch
which would add the other functions).

However, it's not that important after all, just do what you think is
best!

Best regards

Alexander Kurtz

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]