GNOME.org

Re: [Vala] [PATCH] Add libarchive bindings.

From: Michael 'Mickey' Lauer <mickey vanille-media de>
To: Julian Andres Klode <jak jak-linux org>
Cc: vala-list gnome org
Subject: Re: [Vala] [PATCH] Add libarchive bindings.
Date: Sun, 22 Nov 2009 17:32:36 +0100

Hi Julian,

this looks mostly good, however please do not use
[CCode (has_target = false)] unless the upstream API does not provide a
user_data or client_data pointer. In the case of your delegates, it
seems all provide such a client_data pointer, so rather use
[CCode (instance_pos = ...)] for it, otherwise you would limit callbacks
to being static only.

Cheers,

-- 
:M:

Follow-Ups:
- Re: [Vala] [PATCH] Add libarchive bindings.
  - From: Julian Andres Klode

References:
- [Vala] [PATCH] Add libarchive bindings.
  - From: Julian Andres Klode

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]