Re: [Vala] [PATCH] Add libarchive bindings.

[Evan Nemerson <evan coeus-group com>]

On Wed, 2009-12-02 at 12:50 +0100, Julian Andres Klode wrote:
> Am Mittwoch, den 02.12.2009, 12:23 +0100 schrieb Julian Andres Klode:
> > I attached the patch with the changes included. I was not able to do a
> > in-depth test of the bindings, but I expect them to work (I tested the
> > read part and verified all functions 2 times against their C
> > definition). The bindings are against libarchive 2.6.2, upstream is
> > already at 2.7.1, but I was basing this against the version in Ubuntu
> > 9.10 "karmic".
>
> 3rd try, it did not work with the posix profile, it needs a
> --- a/vapi/libarchive.vapi
> +++ b/vapi/libarchive.vapi
> @@ -165,7 +165,7 @@ namespace Archive {
>                 public Result open_memory (void* buff, size_t size);
>                 public Result open_fd (int fd, size_t block_size);
>  #if POSIX
> -               public Result open_FILE (FILE file);
> +               public Result open_FILE (Posix.FILE file);
>  #else
>                 public Result open_FILE (GLib.FileStream file);
>  #endif
> @@ -225,7 +225,7 @@ namespace Archive {
>                 public Result open_fd (int fd);
>                 public Result open_filename (string filename);
>  #if POSIX
> -               public Result open_FILE (FILE file);
> +               public Result open_FILE (Posix.FILE file);
>  #else
>                 public Result open_FILE (GLib.FileStream file);
>  #endif
>
> Attached is a new patch.

Committed. Thanks.

-Evan