Re: [Vala] Vala support for automake

[Ralf Wildenhues <Ralf Wildenhues gmx de>]

Hello Jürg, all,

* Jürg Billeter wrote on Tue, Apr 07, 2009 at 11:20:36PM CEST:
> On Tue, 2009-04-07 at 23:08 +0200, Ralf Wildenhues wrote:
> > Other than that, I haven't yet gotten around to get my system up to date
> > in order to support Vala 0.7 yet.  Would you be so nice as to post
> > verbose log output for all the vala tests?
[...]
> > That will allow me to finish review before finishing my system.
>
> I've attached the verbose test log.

Thanks again for this.

There are still a few things that don't work in the Automake support for
vala, as uncovered by the rest of this discussion.  However, all issues
found so far can arguably be construed as limitations.  The current set
of changes looks like it's quite unlikely to cause regressions for
anyone not using vala, nor for any non-vala features when using vala.
We can fix things incrementally, but we don't need to keep vala support
out of the main Automake for that.

As a minor technical detail, I'm trying to avoid git cherry-picks
starting from post-1.10 Automake, thus instead of your rebase, I
have gone ahead and

- merged part of the next branch into the mh-vala-support branch (so
  your patch would apply cleanly),
- applied your patch, then
- applied the patch below to the mh-vala-support branch, which fixes a
  couple of harmless typos but also declares vala support as initial,
- then merged the mh-vala-support into the current next branch.

It is a bit confusing that ChangeLog and "git log" show things in
different order, but that is more or less unavoidable when using several
parallel lines of development.  I have verified that the result tree of
the above looks identical to your patch series.

I have now pushed the result.  I will soon merge next into master, too.

Cheers,
Ralf

    More minor fixups to vala support.
    
    * automake.in (lang_vala_finish_target): Fix typo in comment.
    * doc/automake.texi (Vala Support): Fix typo.  Declare vala
    support as "initial".
    * NEWS: Likewise, declare vala support as "initial".

diff --git a/NEWS b/NEWS
index fd45cc0..b97dafe 100644
--- a/NEWS
+++ b/NEWS
@@ -2,7 +2,8 @@ New in 1.10c:
 
 * Languages changes:
 
-  - Vala 0.7.0 and later is supported now.
+  - There is initial support for the Vala programming language, when using
+    Vala 0.7.0 or later.
 
 * Miscellaneous Changes:
 
diff --git a/automake.in b/automake.in
index a756089..67e51a4 100755
--- a/automake.in
+++ b/automake.in
@@ -5957,7 +5957,7 @@ sub lang_vala_finish_target ($$)
   $clean_files{"${derived}_vala.stamp"} = MAINTAINER_CLEAN;
 }
 
-# Add output ruless to invoke valac and create stamp file as a witness
+# Add output rules to invoke valac and create stamp file as a witness
 # to handle multiple outputs. This function is called after all source
 # file processing is done.
 sub lang_vala_finish
diff --git a/doc/automake.texi b/doc/automake.texi
index fc3c434..89f1848 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -6603,14 +6603,15 @@ the @code{_LDFLAGS} variable for the program.
 @cindex Vala Support
 @cindex Support for Vala
 
-Automake provides support for Vala (@uref{http://www.vala-project.org/}).
+Automake provides initial support for Vala
+(@uref{http://www.vala-project.org/}).
 This requires valac version 0.7.0 or later.
 
 @example
 foo_SOURCES = foo.vala bar.vala zardoc.c
 @end example
 
-Any @file{.vala} file listed in a @code{_SOURCE} variable will be
+Any @file{.vala} file listed in a @code{_SOURCES} variable will be
 compiled into C code by the Vala compiler. The generated @file{.c} files are
 distributed. The end user does not need to have a Vala compiler installed.