Re: [Vala] Improved foreach

[Jürg Billeter <j bitron ch>]

On Sun, 2008-05-25 at 00:51 -0400, Jamie McCracken wrote:
> Var to be used in foreach

We should certainly allow this, also in Vala. The logic in
ForeachStatement.accept_children is slightly broken as you're missing
visit_end_full_expression in the "var" case. It also seems that you
could simplify some changes in the semantic analyzer by reordering but
difficult to see as you've mixed two change sets, please keep patches
separated.

> Existing local variable (in scope)
>
> This patch is needed for genie although it may be useful for vala too...

Creating local variables on demand for lvalues, when a specific flag is
set, makes more sense, as discussed on IRC. This flag will only be set
by the Genie parser and not by the Vala parser.

Jürg