[Usability] GnomeIconList selection color



Hi,

The background color of selected icons in a GnomeIconList is too dark to make
the text readable (with the default theme, at least). I attached a tiny
screenshot of the problem to this mail.

Also attached a little patch that changes the color used to draw the background
to the same color used for selections in other widgets.
It's not perfect though, other widgets have a slightly lighter color when the
widget is in focus. My gnomecanvas skills were not sufficient to make the 
patch so that it addressed that issue as well, though.

Jorn

Attachment: iconlist.png
Description: PNG image

? stamp-h1
? libgnomeui/diff
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/libgnomeui/ChangeLog,v
retrieving revision 1.100
diff -u -r1.100 ChangeLog
--- ChangeLog	2002/02/09 22:32:52	1.100
+++ ChangeLog	2002/02/10 23:45:33
@@ -1,3 +1,8 @@
+2002-02-11  Jorn Baayen  <jorn nl linux org>
+
+	* libgnomeui/gnome-icon-item.c: use base_gc rather than bg_gc to
+	draw the background color of the selected item.
+	
 2002-02-10  Pauli Virtanen  <ptvirtan cc hut fi>
 
 	* configure.in (ALL_LINGUAS): Added "fi" (Finnish).
Index: libgnomeui/gnome-icon-item.c
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-icon-item.c,v
retrieving revision 1.52
diff -u -r1.52 gnome-icon-item.c
--- libgnomeui/gnome-icon-item.c	2002/02/01 23:32:56	1.52
+++ libgnomeui/gnome-icon-item.c	2002/02/10 23:45:35
@@ -563,7 +563,7 @@
 
 	if (iti->selected && !iti->editing)
 		gdk_draw_rectangle (drawable,
-				    style->bg_gc[GTK_STATE_SELECTED],
+				    style->base_gc[GTK_STATE_ACTIVE],
 				    TRUE,
 				    xofs + 1, yofs + 1,
 				    w - 2, h - 2);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]