Re: [Tracker] trackerbird fixes

[Adrien Bustany <abustany gnome org>]

So the code looks pretty fine to me apart from some indentation 
glitches, and indeed it's a much better idea to use streaming rather 
than synchronous loading... About your remark regarding emails showing 
up as "documents", nmo:Message is a subclass of nfo:TestDocument, so 
that might be a reason.

I think we could squash most of the commits together, I could do that 
locally and push a branch to gnome git, that we can then merge.

Cheers

Adrien

Le 2014-02-06 12:43, Adrien Bustany a écrit :
> Hello Michael,
>
> thanks a lot for the fixes, I'll have a look now. I'm not really using
> the plugin anymore, and I clearly didn't find time to fix things with
> TB 24...
>
> I'll post the review comments, should there be any, on Github.
>
> Cheers
>
> Adrien
>
> Le 2014-02-06 11:16, Michael Lipp a écrit :
> > Hi,
> >
> > after being annoyed about the erroneous trackerbird for quite some 
> > time,
> > I finally decided to dig myself into it. I couldn't find any
> > corresponding bugs in the bug database. I think, people have given up 
> > on
> > this component because it seemed to be unmaintained and thunderbird 
> > has
> > its own search facility (but I like the combined search). Or the bugs
> > never reached "upstream" (you find some in the Suse/Ubuntu/Fedora bug
> > trackers).
> >
> > I fixed the following problems:
> >
> > 1) Trackerbird doesn't work at all with TB24 due to interface changes.
> >
> > 2) Thunderbirds sometimes "freezes" when trackerbird is enabled (you
> > find that in a lot of forums and bug trackers, e.g.
> > https://bugzilla.mozilla.org/show_bug.cgi?id=930492)
> >
> > 3) Improved output via dump statements and also added some reporting 
> > to
> > the thunderbird console in case you haven't enabled dump. This is only
> > done for some "hot spots", though.
> >
> > If you're interested in merging the changes, you can pull them from
> > https://github.com/mnlipp/tracker.
> >
> > What I don't like yet is that mails are found when searching as Mails
> > but also as "Douments" with "Loading..." being displayed. Going to 
> > look
> > into this as well, but I'll have to better understand the data model 
> > first.
> >
> >  - Michael
> >
> > _______________________________________________
> > tracker-list mailing list
> > tracker-list gnome org
> > https://mail.gnome.org/mailman/listinfo/tracker-list
> _______________________________________________
> tracker-list mailing list
> tracker-list gnome org
> https://mail.gnome.org/mailman/listinfo/tracker-list