Re: [Tracker] REVIEW: external-crawler branch, part1

[Philip Van Hoof <philip codeminded be>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/08/2014 10:56, Martyn Russell wrote:
> On 08/08/14 08:58, Philip Van Hoof wrote:

Reply inline below.

> > e5b5280b5f336b80b00d9c9671a72391ab1f0a9b
> >
> > +        data->dbus_path = g_strdup_printf ("/%s", dbus_name); + 
> > +        p = data->dbus_path; +        while ((p = strchr (p,
> > '.')) != NULL) { +            *p++ = '/'; +        } + +
> > data->dbus_name = l->data;

> > D-Bus service names and D-Bus paths shouldn't be correlated like
> > this.
>
> Do you have a better approach in mind? I admit this is quick and
> dirty, but if there is a proper API somewhere, I will use it.

I think it's just completely separate. You need to deal with the two
things as two separate things throughout the flow and code.

There where that dbus-path comes from should include passing the
dbus-name.

I guess there is no API in D-Bus to convert the two because the two
are just different things.

Most people configure them to look like each other, but dbus's service
name of a service and the dbus path of an object are not 1-1
comparable (one service can have multiple objects, so multiple paths -
right?).

Maybe I'm getting a bit old and rusty with D-Bus and/or have things
changed since a few years ago ..

> > It should be possible to have a different D-Bus service name than
> > the object's path. Translating the name to a path by search and
> > replacing . with / doesn't sound right to me.
>
> Without a .desktop file as we currently use, is there a way to do
> this?

With a .desktop file then. :-)

Kind regards,

Philip
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)

iQEcBAEBAgAGBQJT5JahAAoJEEP2NSGEz4aDk0gH/RWtAN5Tr+LCCYGem2twFTPW
NqgBMvDCzznBzxxl+rsKMShhrQ8xPx9Q0hXv41BA9NpvcJUtYhQBKqF1b2qGL5/q
Advn0JR8wlTwLk0mGDQ4YbKh6U0t2J9a8T3FiGZ43m0RY6VmNmcxRSKQW1tkL0me
uETzFt5YAvZgS5JYAAKbKyCsCELG329zPzSVCeRfAzFo8oi4X0rpIGIUsfHka240
OtqM3HhDw6C5w6U60n8Qg8V2DVATG0QbaHiRcK3GLwYeJwnk+cFZfbvT9URKEYmJ
n3Rtb7191vcPf/w5z8Lx6I1AYnxc1EWEpw5VeFzwdIK1FrA2Jbrnb1NfJEUqF+Q=
=R0al
-----END PGP SIGNATURE-----