Re: [Tracker] PATCH: Fix segfault when peeking on an empty TrackerPriorityQueue



Thanks for the patches Jonatan,

I have reviewed and pushed these commits to master.

Kind regards,

Philip

On Thu, 2013-09-12 at 10:57 +0200, Jonatan Pålsson wrote:
Hi list,

I noticed tracker_priority_queue_peek will try indexing outside the
segments array's bounds when the priority queue is empty.

Here's a patch which adds a bounds check:
https://github.com/Pelagicore/tracker-ivi/commit/2a98cb923f99e85dcda10106bf6c338fe11bb8bc

Here's a patch testing the new check, and also showing the issue with
the old code:
https://github.com/Pelagicore/tracker-ivi/commit/3c2f32b0067ffca3ed1fe94ff118cecdb5d8bd58


-- 
Philip Van Hoof
Software developer
Codeminded BVBA - http://codeminded.be



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]