Re: [Tracker] Low hanging fruit from the catacombs of Jolla

[Philip Van Hoof <philip codeminded be>]

On Fri, 2012-12-14 at 08:39 +0000, Martyn Russell wrote:

> * tracker-0.10.37-fix-linking-with-newer-toolchain.patch
> * tracker-0.10.37-fix-linking-with-newer-glib.patch
>
>    These two shouldn't be needed - looks like a fix added to circumvent
>    breaks elsewhere. Not something we should be applying upstream AFAICS.

Yes I agree, adding manual -lgio-2.0 and -lgthread-2.0 is just wrong.

> * tracker-0.10.37-add-userguides-service-for-maemo.patch
>
>    This seems unnecessary with >= 0.14.

Ok. That's strange because they are using 0.14.2.

> * 0005-Fix-missing-gobject-introspection-checks.patch
>
>    This is to disable introspection. So not what we want upstream. There
>    is a --disable-introspection switch already for configure. Perhaps
>    this wasn't around a while ago?

I'll communicate this to them when I speak them again.

> * 0003-tracker-0.9.26-create-tests-aegis.patch
>
>    This is really not for the public version of Tracker I would say.

I even wonder whether Jolla ships with Aegis ...

> * 0002-Tracker-extract-Parse-the-video-filename-to-obtain-e.patch     
>
>    Reviewed, but needs resolution as Aleksander says. Still applies too.

Ok check.

> * 0001-Tracker-0.7.23-desktop-files.patch
>
>    Pushed.

Thanks awesome.

> Thanks for bringing these up Philip.

Np

Kind regards,

Philip

-- 


Philip Van Hoof
Software developer
Codeminded BVBA - http://codeminded.be