Re: [Tracker] Tracker GConf should use DBus session bus

[Martyn Russell <martyn lanedo com>]

On 24/08/12 07:41, Richard Dale wrote:
> Last year Philip Van Hoof commited this change to Tracker's GConf dbus handling:

Hello Richard,

CCing Philip.

> [tracker/gconf-dbus] libtracker-common: Device uses system bus, not session bus
> https://mail.gnome.org/archives/commits-list/2011-April/msg02875.html
>
> It changed the gconf code to use the DBus system bus.
>
> But I couldn't get GConf DBus locale settings support to work with
> Tracker until I changed it back to use the session bus. I haven't been
> able to find any configure option for gconf to make it use the system
> bus instead of the session bus, and so the change just seems wrong to
> me. I think it should be reverted like this:
>
> --- a/src/libtracker-common/tracker-locale-gconfdbus.c
> +++ b/src/libtracker-common/tracker-locale-gconfdbus.c
> @@ -327,7 +327,7 @@ tracker_locale_gconfdbus_init (void)
>
>                  g_message ("Retrieving locale from GConf is ENABLED");
>
> -               connection = g_bus_get_sync (G_BUS_TYPE_SYSTEM, NULL, &error);
> +               connection = g_bus_get_sync (G_BUS_TYPE_SESSION, NULL, &error);

I would have to agree with you, it does look incorrect to me. Philip, 
any comment before we change this? Perhaps there is a reason why you 
used the system bus over the session bus (commonly used everywhere else)?

--
Regards,
Martyn

Founder and CEO of Lanedo GmbH.