Re: [Tracker] Media art detection

[Martyn Russell <martyn lanedo com>]

On 03/10/11 13:50, Sam Thursfield wrote:
> Good afternoon,

Hi,

> I just filed https://bugzilla.gnome.org/show_bug.cgi?id=660784 with a
> rewrite of the album art detection code, which now supports detecting
> video posters as well.
>
> It seems like it would make sense to s/albumart/media_art over the
> code base, anyone in favour?

Sounds fine to me.

> Also, I wrote a couple of unit tests for the
> tracker_albumart_find_external() function, but using it requires
> moving the tracker-albumart functions into libtracker-extract instead.
> Which would be fine except it requires TrackerStorage which is in
> libtracker-miner, which would introduce a dep in libtracker-extract on
> libtracker-miner. Any ideas on this one? It seems the options are

Yea :/

>    1) move TrackerStorage into libtracker-common

It was there before :P

Seems we use this to know if we're on a removable device and if so we 
copy the media art to ~/

After a quick check with Philip, this is just for Nokia device 
primarily. We could just patch them on this.

Also, the removable check (I wonder) could be done once on init. I 
suspect not though :/ tracker-extract *does* link with libtracker-miner, 
so if we can pass things from there it would be better I agree.

>    2) come up with a way of exposing functions in tracker-extract for testing
>
> And as a final thinking point, wouldn't it be nice if we could have an
> nie:MediaArtImage class so that when a file is decided to be media
> art, there's no danger of it showing up in searches for photos etc?

No there shouldn't be.

> I'm not entirely sure what the best way to do this would be.

The storage seems the only issue here. We can move this to 
libtracker-common again but I would rather not if we can avoid it.

--
Regards,
Martyn

Founder and CEO of Lanedo GmbH.