Re: [Tracker] Debian Tracker 0.10.0/Evolution 2.32: not mining

[Philip Van Hoof <philip codeminded be>]

On Fri, 2011-03-18 at 10:34 +0000, Martyn Russell wrote:
> On 18/03/11 10:26, Philip Van Hoof wrote:
> > On Fri, 2011-03-18 at 10:12 +0000, Martyn Russell wrote:
> > > On 18/03/11 09:12, Joost Kraaijeveld wrote:
> > > > Hi,
> > >
> > > Hi,
> > >
> > > > I bumped everything to debug level and now I see in this about Evolution
> > > > in the logfiles (grep olution *) :
> > >
> > > Philip, this looks like we need to update our evo plugin? Any comment?
> >
> > Yes, sounds like it does need to be ported in the evo plugin to use
> > delete-graph-where-graph instead of the old drop-graph.
> >
> > The TrackerSparqlBuilder's drop_graph function should also be removed,
> > btw.
>
> I believe this is public API, so it should at the very least be marked 
> as deprecated and kept for 0.10.x.

Sure ok. But tracker-store doesn't understand it any more. So
TrackerSparqlBuilder shouldn't allow it, as the recipient of that
doesn't understand it anyway.

So not only is it deprecated: when used, it'll create errors.

Tbh I think it should be taken out by emergency, forcefully. Perhaps by
keeping the symbol but letting it do g_critical() and add #warning or
maybe even #error in case if -DDISABLE_DEPRECATED

Cheers,

Philip



-- 


Philip Van Hoof
freelance software developer
Codeminded BVBA - http://codeminded.be