Re: [Tracker] Does Tracker really needs a keyfile?

[Adrien Bustany <abustany gnome org>]

Le Sat, 09 Oct 2010 15:45:12 +0200,
Philip Van Hoof <spam pvanhoof be> a écrit :

> On Sat, 2010-10-09 at 10:21 +0100, Martyn Russell wrote:
> > On 09/10/10 09:19, Adrien Bustany wrote:
> > > as mentionned on
> > > http://live.gnome.org/Tracker/Documentation/WebMiners/Association,
> > > there is a graphical interface, the source code is at
> > > git://git.mymadcat.com/tracker-miner-manager . It is however a
> > > pretty young project, but it should work anyway.
> > > Once configured, the miner will fetch the photos from Flickr, and
> > > they'll be in the Tracker DB (you can identify them looking at
> > > their nie:DataSource property). The Flickr miner does need a
> > > configuration file to store its configuration settings. It will
> > > store the passwords either in gnome-keyring or in a keyfile
> > > (unencrypted). Don't hesitate to ask me if you have more
> > > questions, I'm abustany on IRC.
> >
> > We should probably add this to the Tracker code base at some point.
>
> I agree, let's get this tracker-miner-manager into the upstream
> project, if that's ok for Adrien.
>
> The code could use some love, though :-)
>
> Now type `make' to compile tracker-miner-manager
> pvanhoof lors:~/repos/madcat/tracker-miner-manager$ make
> make  all-recursive
> make[1]: Entering directory
> `/home/pvanhoof/repos/madcat/tracker-miner-manager' Making all in src
> make[2]: Entering directory
> `/home/pvanhoof/repos/madcat/tracker-miner-manager/src' GEN
> libassociation-module-token.vala.stamp warning: D-Bus GLib is
> deprecated, use GDBus association-module-token.vala:29.3-29.36:
> error: 3 missing arguments for `void Gtk.Box.pack_start (Gtk.Widget
> child, bool expand, bool fill, uint padding)' hbox_top.pack_start
> (label_status); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> association-module-token.vala:30.3-30.40: error: 3 missing arguments
> for `void Gtk.Box.pack_start (Gtk.Widget child, bool expand, bool
> fill, uint padding)' hbox_top.pack_start (button_associate);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> association-module-token.vala:31.3-31.30: error: 2 missing arguments
> for `void Gtk.Box.pack_start (Gtk.Widget child, bool expand, bool
> fill, uint padding)' pack_start (hbox_top, false);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> association-module-token.vala:38.3-38.35: error: 3 missing arguments
> for `void Gtk.Box.pack_start (Gtk.Widget child, bool expand, bool
> fill, uint padding)' hbox_info.pack_start (label_info);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> association-module-token.vala:39.3-39.36: error: 3 missing arguments
> for `void Gtk.Box.pack_start (Gtk.Widget child, bool expand, bool
> fill, uint padding)' hbox_info.pack_start (button_done);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> association-module-token.vala:40.3-40.43: error: 2 missing arguments
> for `void Gtk.Box.pack_start (Gtk.Widget child, bool expand, bool
> fill, uint padding)' vbox_bottom.pack_start (hbox_info, false);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> association-module-token.vala:47.3-47.42: error: 3 missing arguments
> for `void Gtk.Box.pack_start (Gtk.Widget child, bool expand, bool
> fill, uint padding)' vbox_bottom.pack_start (scrolled_window);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> association-module-token.vala:48.3-48.54: error: 2 missing arguments
> for `void Gtk.Box.pack_start (Gtk.Widget child, bool expand, bool
> fill, uint padding)' vbox_bottom.pack_start (label_webview_status,
> false); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> association-module-token.vala:49.3-49.32: error: 2 missing arguments
> for `void Gtk.Box.pack_start (Gtk.Widget child, bool expand, bool
> fill, uint padding)' pack_start (vbox_bottom, true);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Compilation failed: 9 error(s), 1
> warning(s) make[2]: *** [libassociation-module-token.vala.stamp]
> Error 1 make[2]: Leaving directory
> `/home/pvanhoof/repos/madcat/tracker-miner-manager/src' make[1]: ***
> [all-recursive] Error 1 make[1]: Leaving directory
> `/home/pvanhoof/repos/madcat/tracker-miner-manager' make: *** [all]
> Error 2 pvanhoof lors:~/repos/madcat/tracker-miner-manager$ $VALAC
> --version pvanhoof lors:~/repos/madcat/tracker-miner-manager$ 
Hmm, that looks like my vapi has more default parameter values than
yours... I don't remember which vala version I used, probably master.
In any case, it's a trivial fix.
Before proposing that for inclusion, I'd maybe like more testing from
you guys, especially to spot this type of mistake ;)
I'll push a fix for this one now.
 
> Cheers,
>
> Philip