Re: [Tracker] miner-flickr-review branch review

[Martyn Russell <martyn lanedo com>]

On 29/04/10 13:49, Adrien Bustany wrote:
> On Thu, 29 Apr 2010 10:30:23 +0100, Martyn
> > Which looks like it isn't needed?
> Uuuh actually it's for nao:hasTag, I didn't read that line right :)
> So yes it's needed

Ah right you are, got confused by the diff there:

@@ -34,6 +35,7 @@ nao:description a rdf:Property ;
 nao:hasTag a rdf:Property ;

Assumed nao:description :)

> the argument you want to pick printf ("%2$s %1$s", "rocks",
> "Tracker") prints "Tracker rocks"

Very nice! :)

> > Can you use ifndef then please.
> I said "I don't think so" :) I tried actually, and it doesn't work.
> I could probably patch Vala for that, but that's low priority.

Ah I see. I didn't realise Vala didn't support that.

> Well so #ifndef is not fixable, but I fixed the initial status. If
> it's OK to merge, let's merge :) This weekend I'll try to hack up a
> quick gtk interface for association. We wanted to see with rishi how
> we could unify credential storage, but meanwhile an ad-hoc solution
> will do.

That's fine then given we know what the reason is for it.

I will merge before releasing. Thanks Adrien.

--
Regards,
Martyn