Re: [Tracker] Request for review of writeback branch
- From: Martyn Russell <martyn lanedo com>
- To: Philip Van Hoof <spam pvanhoof be>
- Cc: tracker-list gnome org
- Subject: Re: [Tracker] Request for review of writeback branch
- Date: Wed, 25 Nov 2009 13:01:36 +0000
On 25/11/09 11:58, Philip Van Hoof wrote:
On Wed, 2009-11-25 at 09:14 +0000, Martyn Russell wrote:
On 22/11/09 13:45, Philip Van Hoof wrote:
Hi guys!
[cut]
It looks really good though Philip and Carlos. Thanks for getting
started on this.
I have committed some code clean ups.
Are there things left to do after your code-cleanup commit?
No. But I did have some open questions in my email which I would like to
discuss here.
I took a look at the commit and it looks like you fixed most of the
issues you mentioned.
Yea I did. Since I was there reviewing/understanding the code, I figured
it would save us both time.
ps. I rebased the writeback branch and merged it with master. You might
have to check it out again to avoid massive conflicts.
OK great, thanks.
--
Regards,
Martyn
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]