Re: [Tracker] [PATCH] tracker-extract-mp3.c: remove trailing whitespaces
- From: "Juan A. Suarez Romero" <jasuarez igalia com>
- To: Martyn Russell <martyn lanedo com>
- Cc: tracker-list gnome org
- Subject: Re: [Tracker] [PATCH] tracker-extract-mp3.c: remove trailing whitespaces
- Date: Thu, 05 Nov 2009 15:40:53 +0100
On Thu, 2009-11-05 at 13:26 +0000, Martyn Russell wrote:
Hi, I have fixed this by using g_strstrip() instead and in
tracker_coalesce() so it occurs for most metadata not just these in the
mp3 extractor.
Good!
At first I thought also in using g_strstrip(). But then some doubts came
to my mind.
While filling a tag could be quite common adding some trailing
whitespaces, it shouldn't be adding leading whitespaces.
It's like when you write code: while it's easy to add inadvertently
trailing whitespace, you always see leading whitespaces.
So I considered that if a tag have leading whitespaces, is because user
added it on purpose.
J.A.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]