Re: [Tracker] [patch] split TrackerHal into TrackerStorage and TrackerPower and re-organise into backend

[Jürg Billeter <j bitron ch>]

On Fri, 2009-05-15 at 15:53 +0100, Richard Hughes wrote:
> On Fri, May 15, 2009 at 3:15 PM, JÃrg Billeter <j bitron ch> wrote:
> > Thanks for the update. I've fixed one small issue (set
> > battery_percentage before calling g_object_notify) and pushed it.
>
> Cool, good catch. I've now attached another patch that adds the
> DeviceKit-power backend, which is preferred by default over HAL if
> it's available. You can change the default backend as you wish, but in
> Fedora we'll be using DK-p by default, and compiling out the HAL bits.
> It's a much simpler (and better IMHO) interface than when we are using
> HAL, as I hope you'll see. It also doesn't incorrectly define you
> being on battery with a wireless mouse inserted, and treats on UPS
> power as system low power. i.e. a much easier interface to not use
> incorrectly.

Sorry for the delay, I was in military service. The patch looks fine,
and using DeviceKit-power by default sounds fine to me, too. I've pushed
it to master.

> It's been compile tested as much as possible, but I can't test
> trackerd as I'm now getting compile errors in unrelated areas in the
> codebase. I appreciate it is git master, so I'm not sure if you're too
> bothered. Anyway, my error is:
>
> tracker-data-query.c:466: error: âTrackerSparqlQueryâ undeclared
> (first use in this function)

This means that you've been using a too old Vala version, master
requires Vala 0.7.x. autogen.sh should have complained. Unfortunately,
that check won't work when not rerunning autogen.sh.

Thanks,
JÃrg