Re: [Tracker] tracker-tags-plugin for Nautilus



On 19/12/09 00:17, Debarshi Ray wrote:
extension_get_background_items in tracker-tags-extension.c is broken
because it gets invoked when one has right clicked the background, ie.
without selecting any file(s). In that case in menu_tags_activate_cb
md->data is not a list of NautilusFileInfo * but a
NautilusMenuProvider *. I am not sure what we want to offer here.

I see. Yes, I have fixed it now. Basically, I just removed any background action. Since we have no files to tag, it makes it hard to tag anything there. I haven't checked, but perhaps there is an API to get the current background image in Nautilus? Either way, I also fixed the crash in case we enable the background function again.

Also it looks like it is not possible to remove tags from UI? Was it
intentional?

Yes. You can, but only if you remove ALL tags from other files. There is no way to remove all tags for every file in one place. It works on the principle that if you uncheck the tag for each file that has the tag, it is automatically removed. I did wonder if we should have a "remove for all files" type button, but so far I couldn't see where to put such a button logically in the UI. It would take 5 minutes to do though :)

Thanks for spotting the issue ;)

--
Regards,
Martyn



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]