Re: [Tracker] status of 0.6.90?



2008/10/7 Martyn Russell <martyn imendio com>:
Michael Biebl wrote:
2008/10/6 Martyn Russell <martyn imendio com>:
Michael Biebl wrote:

Other points:
* config file of tracker-applet is ~/.config/trackertracker-applet.cfg
* duplicated code in src/libtracker-common/tracker-config(uration).[ch]
* API/ABI break in libtracker-gtk
Are you referring to the missing:

 tracker_vfs_format_file_size_for_display()

Right, I was referring to this one.
I just checked 0.6.6 and you are right, this function is not exported
in the header file, but the symbol is in the lib.
So we would break ABI, but not the API.

I don't see it in the code base at all. So I don't know why it is in the
 library.

It's in src/libtracker-gtk/tracker-metadata-tile.c in 0.6.6 and not
anymore in current trunk.
Unfortunately *all* the history got lost after the indexer-split
merge. So I can't exactly say, when and why it was removed.


Maybe it was just a missing "static" in 0.6.6, dunno if this symbol
was ever considered to be exported.

That's a good question.

To avoid accidental symbol exports in the future, we could use a
versioning script, where we list the exported symbols explicitely.

Do you have such a script readily available?

No, but I could write one. It is not rocket science.

You basically create a file like
libtracker-gtk.ver which contains:

{
global:
  tracker_create_simple_keyword_liststore;
  tracker_get_all_keywords;
  ...
local:
  *;
}

And use the following LDFLAGS:
-Wl,--version-script=$(srcdir)/libtracker-gtk.ver

Cheers,
Michael



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]