Re: [Tracker] Memory leak in tracker-indexer

[Carlos Garnacho <carlos imendio com>]

Hi!

On miÃ, 2008-10-01 at 11:48 +0100, Martyn Russell wrote:

<snip>

> We have had this issue before. That is why we now use g_try_malloc0()
> so
> we don't just crash when we can't allocate the memory. I know this
> isn't
> the best solution but I too have seen it eat 1.5gb of memory (not for
> me
> anymore, but then I don't run 64bit) but why don't we add a simple
> check
> in here and if len is > some arbitrary figure then we assume it is
> crack
> and bomb out there and then? This figure could be 100Mb or something?
>
> Of course the real solution is to fix it but I fear this problem may
> persist because from what I hear, passing these files is a dark art
> and
> if you get one part of it wrong then this sort of issue can come up
> again very easily. We should probably add some checks to prevent this
> happening.

My main concern here is that people would just notice missing mails,
without any clue about how or why has this happened... far from ideal
IMHO :(

-- 
Carlos Garnacho
Imendio AB - Expert solutions in GTK+
http://www.imendio.com