Re: [Tracker] Patch for review: refactoring thumbnailing and cleaning up volumes's thumbnails after a long period of being unmounted

[Martyn Russell <martyn imendio com>]

On 24/11/08 15:47, Philip Van Hoof wrote:
> Please review this patch.
>
>    * Refactors the thumbnailer API to an internal API in
>      libtracker-common
>    * Making the tracker-albumart.c use the internal API
>    * Include changes in tracker-indexer to use libtracker-common instead
>    * Added tracker_thumbnailer_cleanup which uses the Cleanup DBus API of
>      the thumbnailer-DBus-spec
>    * Added tracker-cleanup.c as a module that deals with cleaning up data
>      about volumes that have disappeared for a long time
>    * Adjusted the volume management to record unmount times
>    * Removed tracker-thumbnailer.c/h from tracker-indexer's tests setup
>
> pvanhoof tinc:~/repos/gnome/tracker/trunk$ svn status | grep ^M
> M      src/tracker-indexer/tracker-metadata-utils.c
> M      src/tracker-indexer/tracker-main.c
> M      src/tracker-indexer/tracker-dbus.c
> M      src/tracker-indexer/tracker-indexer.c
> M      src/tracker-indexer/Makefile.am
> M      src/trackerd/tracker-main.c
> M      src/trackerd/Makefile.am
> M      src/tracker-extract/tracker-albumart.c
> M      src/libtracker-common/Makefile.am
> M      tests/tracker-indexer/Makefile.am
> M      configure.ac
> M      data/db/sqlite-stored-procs.sql
> M      data/db/sqlite-tracker.sql
> pvanhoof tinc:~/repos/gnome/tracker/trunk$ svn status | grep ^D
> D      src/tracker-indexer/tracker-thumbnailer.c
> D      src/tracker-indexer/tracker-thumbnailer.h
> pvanhoof tinc:~/repos/gnome/tracker/trunk$ svn status | grep ^A
> A      src/trackerd/tracker-cleanup.c
> A      src/trackerd/tracker-cleanup.h
> A  +   src/libtracker-common/tracker-thumbnailer.c
> A  +   src/libtracker-common/tracker-thumbnailer.h
> pvanhoof tinc:~/repos/gnome/tracker/trunk$

Thanks for the patch Phillip. I have committed this now.

--
Regards,
Martyn