Re: [Tracker] Please review, thumbnail cleanup code




Thanks for the review and path improvements, will be committing this in
a minute.

On Mon, 2008-11-24 at 12:44 +0000, Martyn Russell wrote:
On 21/11/08 15:46, Philip Van Hoof wrote:
Please review this patch

Hi Phillip,

I have attached an update to your patch. I have changed:

* Make use of GStaticPrivate for the static module data in the 
tracker-thumbnailer module.

* Added an init() and shutdown() function for the tracker-main.c to call 
so we clean up the list and timeouts, etc.

* Added some messaging so we know what is going on a bit.

* Removed all imagemagick code. Some more maintenance is needed to 
remove the other files in the source tree.

* I reverted the tracker-file-utils.c changes, since they are obviously 
for the path->uri work JÃrg is doing.

See what you think.

-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]