Re: [Tracker] why only enable inotify on tracker trunk?

[Martyn Russell <martyn imendio com>]

Jerry Tan wrote:
> > Jerry Tan wrote:

Hi Jerry,

> > > I remember that tracker 0.6.6 support both inotify and gamin,
> > > so it can work on solaris since gamin is there.
> > >
> > > but when I check out trunk code, I found that it has only support for
> > > inotify,
> > > which only exists on linux.
> > >     
> >
> > We support whatever GLib supports, which is inotify, fam, fen and win32.
> > For Linux we use libinotify ourselves and not GLib's inotify because it
> > doesn't support MOVE events properly.
> >
> > There is a bug upstream about this:
> >
> >   http://bugzilla.gnome.org/show_bug.cgi?id=547890
> >
> >   
>
> So, the current trunk is inotify only, right?

No, it shouldn't be. It should use libinotify in src/ if it exists, if
not it will fall back to GIO which will use FAM, etc.

> I found that I have to add my patch here ,not to build with inotify on
> solaris.

I just committed a fix. Slightly different to yours. In fact, the same
check that GLib does to see if inotify support is available.

> AM_CONDITIONAL(HAVE_INOTIFY, test "$have_inotify" = "yes")
> Index: src/Makefile.am
> ===================================================================
> --- src/Makefile.am     (revision 2435)
> +++ src/Makefile.am     (working copy)
> @@ -6,6 +6,8 @@
>
> if HAVE_INOTIFY
> build_libinotify = libinotify
> +else
> +build_libinotify =
> endif
>
> if !USING_EXTERNAL_QDBM

The "else" statement there shouldn't be necessary.

-- 
Regards,
Martyn