Re: [Tracker] *-private.h files

[Jamie McCracken <jamiemcc blueyonder co uk>]

On Sat, 2008-01-05 at 04:45 +0100, Jaap A. Haitsma wrote:
> On Jan 4, 2008 10:10 PM, Jamie McCracken <jamiemcc blueyonder co uk> wrote:
> > On Fri, 2008-01-04 at 20:34 +0100, Jaap A. Haitsma wrote:
> > > Hi,
> > >
> > > I was hacking a bit on the tracker source code and found several
> > > *-private.h files
> > >
> > > ./tracker-applet/tracker-applet-private.h
> > > ./tracker-preferences/tracker-preferences-private.h
> > > ./tracker-preferences/tracker-configuration-private.h
> > >
> > > These files only get included by their *.c counterpart.
> > >
> > > Any reason why these *-private.h are not placed at the top of the
> > > respective c file. That seems more logical to me, because
> > > 1) that's the way it's normally done
> > > 2) putting it at the top of the c files makes it really private (i.e.
> > > there's no option to even include it in another file)
> > > 3) It's one file less to look into
> > >
> > > If you agree than I can make the changes in SVN.
> >
> > sure pls do - thanks
> Commited
>
> 2008-01-05  Jaap Haitsma  <jaap haitsma org>
>
>       * src/tracker-applet/Makefile.am:
>       * src/tracker-applet/tracker-applet-private.h:
>       * src/tracker-applet/tracker-applet.c:
>       * src/tracker-preferences/Makefile.am:
>       * src/tracker-preferences/tracker-configuration-private.h:
>       * src/tracker-preferences/tracker-configuration.c:
>       * src/tracker-preferences/tracker-preferences-private.h:
>       * src/tracker-preferences/tracker-preferences.c:
>       Remove *-private.h files. Just put these declarations in the
>       respective *.c files
>
> Couple of things I noticed now and I can fix
>
> 1) Now all the static function declarations are in the beginning of
> the c file, but ofcourse if you reorder the code a bit this is not
> necessary (I always use this because it saves time and typing if you
> decide to change the arguments in the function. I see that also in
> other parts of the tracker code  base)
> If you want I can reorder the functions so that the prototypes are not
> necessary anymore

I usually avoid prototypes but other contributions included them and it
would not seem right to force them to change. Probably best to leave as
is in case it upsets one of the contributors

> 2) the tracker-applet sources don't have a license at the top. I can
> put a license at the top.
> Should I put you (Jamie) as the copyright owner?
>
> 3) tracker-preferences mixes CamelCase and lowercase with underscores
> for function names. I can change this to all lowercase with
> underscores. (I'm assuming you follow the normal GNOME coding style)


pls clean up 

all that code originally belongs to Saleem Abdulrasool
(compnerd gentoo org) with heavy modifications by me so pls add us both
to any missing copyright

thanks for doing this 

jamie


> Jaap