Re: [Tracker] xmp:- file in ~

[Jamie McCracken <jamiemcc blueyonder co uk>]

On Sat, 2008-02-23 at 12:47 +0100, Michael Biebl wrote:
> 2008/2/23, Michael Biebl <mbiebl gmail com>:
> > 2008/2/23, Michael Biebl <mbiebl gmail com>:
> >
> > > 2008/2/23, Jamie McCracken <jamiemcc blueyonder co uk>:
> >  >
> >  > >
> >  >  > apparently this has been fixed by compnerd:
> >  >  >  https://bugs.launchpad.net/ubuntu/+source/tracker/+bug/194221
> >  >
> >  >
> >  > I don't see, how adding a tif and gif thumbnailer could fix this issue.
> >  >
> >
> >
> > I think the culprit is src/tracker-extract/tracker-extract-imagemagick.c:
> >
> >  #ifdef HAVE_EXEMPI
> >
> >         gchar *xmp;
> >
> >         argv[0] = g_strdup ("convert");
> >         argv[1] = g_strdup (filename);
> >         argv[2] = g_strdup ("xmp:-");
> >         argv[3] = NULL;
> >
> >         if (tracker_spawn (argv, 10, &xmp, &exit_status)) {
> >                 if (exit_status == EXIT_SUCCESS && xmp) {
> >                         tracker_read_xmp (xmp, strlen (xmp), metadata);
> >                 }
> >         }
> >  #endif
> >  }
>
> Does this code actually make any sense at all?
> Why do we run convert over the image (which seems to only make an
> exact copy of the image).
>
> I'm a bit puzzled atm.

its supposed to extract xmp profile to stdout (and not to an xmp file)

I have temporarily disabled it in latest svn until we can get convert to
do this properly

jamie