Re: [Tracker] work items for 0.6.5

[Halton Huo <Halton Huo Sun COM>]

Jamie, 

As your request, the patch for feature 3) is ready, please review it.

Thanks,
Halton.
On Fri, 2008-02-01 at 09:52 -0500, Jamie McCracken wrote:
> > > 3) Constantly changing files - we should ignore these especially
> > > bittorrent ones. Perhaps keep a small size-limited stack of
> recently
> > > indexed files and if one of those files has been changed more than
> 10
> > > times in a few minutes we should ignore them until trackerd next
> > > restarts
> >
> > It is like prison rule. 
> >
> > Suppose these stack is like:
> >
> > file_name      first_change_time     change_accounts
> > /a             11111                 3
> > /b             22222                 8
> > /c             33333                 1
> >
> > When a file is changed, 
> >   if ((current_time - first_change_time) > MAX_DURATION) {
> >     first_change_time = current_time
> >   } else {
> >     change_accounts ++;
> >     if (change_accounts < MAX_CHANGE_TIMES) {
> >       //reflect this change
> >     } else {
> >       // ignore this change
> >     }
> >   }
>
> thats pretty much it but make sure it applies to files only (and not
> emails or conversations)
>
> when we ignore the file - add it to an ignore list in memory. When
> trackerd exits, save that list to file. When trackerd is next
> restarted
> load the list and index the entries and then reset it.
>
> > Stop here if my thinking is totally wrong.
> >
> > If my proto is not wrong, the question is where to have this stack?
> > (1) In memory
> >    There will have a long list for all changed files, even it is
> changed
> > only once.
> >    
> > (2) In database
> >    Add a property for each file in Service table. Could be slower.
>
>
> it would not be slower as such cause we are updating the mtime in that
> table anyhow whenever it changes. However we dont want to do a db
> change
> at this point so (1) would be better for now
>
> > Any idea?
>
> Use a fixed size LIFO stack of 50 items max in memory 
>
> you can use a static array if you like or if you prefer the glib
> double
> queue 
>
> http://library.gnome.org/devel/glib/unstable/glib-Double-ended-Queues.html)
>
>
> but make sure you pop tail to keep its size limited

Attachment: tracker-frequent-change.diff
Description: Text Data