Re: [Tracker] Support in Tracker for ultra-new Evolution installs that use SQLite for the summary format
- From: "Ivan Frade" <ivan frade gmail com>
- To: "Philip Van Hoof" <spam pvanhoof be>
- Cc: Carlos Garnacho <carlos_garnacho yahoo es>, Ivan Frade <Ivan frade nokia com>, Evolution Hackers <evolution-hackers gnome org>, Tracker mailing list <tracker-list gnome org>
- Subject: Re: [Tracker] Support in Tracker for ultra-new Evolution installs that use SQLite for the summary format
- Date: Thu, 11 Dec 2008 23:58:36 +0200
hi philip,
short comment (the tablet is not the best device to review patches):
can we call this module "evolution224" and keep also the old module?
we could choose between one or other with a flag in compilation time
(the distributions will choose the correct for them)
regards,
Ivan
On 12/11/08, Philip Van Hoof <spam pvanhoof be> wrote:
This patch makes ultra-new Evolution installs work again with Tracker.
There's one problem and that is that the query will only find E-mails in
the INBOX folder. You can easily find the Query and figure out what the
problem is:
The design that Carlos made assumes that for each folder there's a
"summary" file. In the new Evolution cache format there's just one
"folders.db" for each account.
I could do a generated UNION select after first doing "select * from
folders" on folders.db and then generating a query that includes all
folders. I just have not done this for now and instead I'm just using
INBOX and I'm neglecting the other folders.
This is NOT the same as the proposal that I am doing at (a). This is
instead a ad-hoc solution for the new situation (Evolution using SQLite
for the summaries). I find this solution rather nasty, to be honest.
(a) http://live.gnome.org/Evolution/Metadata
For Carlos: I have also fixed a serious problem in evolution-pop.c,
which is by the way unaffected by Evolution's changes (and works, if you
just apply the patch that I included in this larger patch). The POP
support's get_message_metadata was not returning metadata.
This was crashing my tracker-indexer (as seemingly my compiler was
putting "return 0x2" where the return was omitted, and the memory I have
at 0x2 didn't dereference TrackerModuleMetadata's members very well).
Please review and/or rework the patch.
--
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://pvanhoof.be/blog
http://codeminded.be
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]