Re: [Tracker] Uninitialized variable in tracker-files.c

[Luca Ferretti <elle uca libero it>]

Il giorno mar, 09/12/2008 alle 09.38 +0000, Martyn Russell ha scritto:
> On 08/12/08 19:54, Luca Ferretti wrote:
> > I was checking tracker-utils/*c due to some localization issues (more on
> > this later). In tracker-files.c shouldn't it be:
> >
> >   static gint           limit = 512;
> > -static gint            offset;
> > +static gint            offset = 0;
>
> Hi,
>
> As far as I am aware, the compiler should initialize variables not set 
> in static statements to NULL or 0. 

All compilers (gcc, sun, ibm)?

> The only reason we do it for limit is 
> because we want something other than 0 of course.

Better code readability?

While it's not needed, I can't see any issue adding them. I'm reviewing
that GOption stuff, so I could add NULL, 0 and FALSE at the same time...