Re: [Tracker] [PATCH] Parsing dates with standard C functions

[Jamie McCracken <jamiemcc blueyonder co uk>]

On Mon, 2008-04-07 at 17:50 +0300, Ivan Frade wrote:
> Hi all,
>
> In tracker-extract.c -> tracker_generic_date_extractor (...), there is a
> gchar timezone_buffer[6]. 
>
>  Some times it is used without initialization in g_strconcat at the end
> of the same function. This causes that some times the Image:Date field
> disappear from tracker-extractor's output.
>
>  Here is a patch that:
>
> 1) Replace the hand-made code to parsing dates with the standard C
> functions strptime and strftime. This solve the bug :)
>
> 2) Replace iso8160 with iso8601. The standard to date and time format is
> iso 8601.
>
>  The patch: http://bugzilla.gnome.org/show_bug.cgi?id=526727
>
>  Please review,

quick review looks fins

can you commit and close bug (I added you to tracker's bugzilla devs so
you can close bugs)

thanks

jamie