Re: [Tracker] Thunderbird support. Patches for rev. 836

[jamie <jamiemcc blueyonder co uk>]

On Tue, 2007-09-11 at 12:06 +0100, Michal Pryc wrote:
> Hello Jamie,
>
> I am sending set of patches (patches.836.tar.gz) that adds thunderbird 
> support. Those patches are made for revision 836 and contains also fixes 
> for Solaris install.
>
> The names and descriptions are the same as in the previous e-mail that I 
>   have send to the mailing list, except one file:
> thunderbird-extension.diff
>
> which is no more needed, since we've agreed that we will put the 
> extension on the tracker svn.
>
> The attached file thunderbird-extension.tar.gz should be uncompressed 
> and put into directory trunk/ of tracker svn. If not than the patches 
> will break the build, since there will be missing 
> thunderbird-extension/Makefile
>
> To build the extension use the flag
> ./autogen --with-thunderbird-extension
>
> This will generate the tracker.xpi file. I have already made changes, so 
> all the strings in the extension are s/beagle/tracker.


Hi 

I have added most of this with some changes:


1) I have not added the extension to the tracker folder yet as its
experimental and not finished yet. Once I have ubuntu stuff out of the
way in about 2 weeks and more people have tested it then we can add it
(with beagle filenames removed if possible)

2) I have removed reference to generate makefile in extension. I prefer
the extension to be external for now. Also removed refs from readme.

3) I have not added support for tracker preferences yet as its not ready
for users

4) Some of the coding style is not appropriate - we use tab indent and
always have a space between function name and opening bracket

blocks for if/for/while are done as follows:

if (blah) {
        blah;
} else {
        blah;
}

Can you correct any pls that were applied

5) I removed the tracker_parse_log_message_and_add_missing_formatting
(it did not compile as well as you inlined int in the for)

we already have a generic tracker_string_replace function in
tracker-utils.c so I used that instead (and fixed leak too)

(always a good idea to use GString when appending strings)


I have not had time to build or test the extension but I wanted to get
your code changes in place. If any problems with it let me know...

jamie.