Re: [Tracker] [PATCH] sanitizing tracker-handler behavior when t-s-t is missing
- From: "Mikkel Kamstrup Erlandsen" <mikkel kamstrup gmail com>
- To: "Marcus Fritzsch" <fritschy googlemail com>
- Cc: Tracker-List <tracker-list gnome org>
- Subject: Re: [Tracker] [PATCH] sanitizing tracker-handler behavior when t-s-t is missing
- Date: Wed, 12 Sep 2007 10:33:55 +0200
2007/9/11, Marcus Fritzsch <
fritschy googlemail com>:
Hey,
here is the patch for the bug reported in the debian BTS[1] regarding
tracker-handler and t-s-t being missing. With this patch,
tracker-handler shows a gtk dialog on the first entered search when
t-s-t is missing and no action will be taken.
This report affects only the deskbar <2.19 handler as with the new
deskbar prerequisites for different handlers in one file are handled
correctly.
Cheers, Marcus
[1]
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=441889
As I mentioned on IRC, I don't think it is a good idea to bring up a warning dialog on every user session. The fast, but ugly, solution is just to have a warning printed to stdout (deskbar <
2.19 does not have a logging system) .
A more correct solution seems to address what I see in line 394, of tracker-handler.py :
#'requirements': TrackerSearchToolHandler.requirements, # XXX makes deskbar
2.18.1 not load the handler!!
commented out - the correct solution seems more to fix this. No?
Cheers,
Mikkel
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]