Re: [Tracker] [PATCH] safe tmpfile usage

[jamie <jamiemcc blueyonder co uk>]

On Fri, 2007-11-23 at 01:30 +0100, Michael Biebl wrote:
> Hi,
>
> currently our (external) filter scripts are lacking resp. buggy in several ways:
> - they don't respect the TMPDIR environment variable
> - not safe from a security pov [1]
> - buggy (st vs $st)
> - unnecessary cat calls
> - create files in $HOME (which unnecessarily get picked up by tracker)
>
> The attached patch addresses these issues. I used mktemp to implement
> the creation of safe tmpfiles. TTBOMK all modern linux/solaris
> distributions ship tool.
> I'm posting this patch for wider review. If you know of any platform
> (we support) that doesn't ship mktemp, please let me know.

they look fine at first glance - no worries about you committing this
already :)

jamie