Re: [Tracker] [PATCH] safe tmpfile usage



2007/11/24, Halton Huo <Halton Huo sun com>:
Hi Michael,

Does it means no comments is auto-approval? How long will be the
timeout? Then can I commit the patch for t-p?


Hi Halton,

I had discussed these issues with jamie on irc and he already approved
it more or less.
I simply wanted to get some input on the usage of mktemp.
The patch itself is rather straigthforward and obvious and as such
doesn't really need much review.

So I don't think that we can take this example as a guideline for auto-approval.
For more invasive code changes it makes sense if jamie gives his ok (I
don't know if this is the case for your patch. Haven't taken a look at
it).

In addition I'll be offline for some days now and wanted to have this
patch in 0.6.4. That's why I committed it today without waiting
longer.

Cheers,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]