Re: [Tracker] [Fwd: libtracker-gtk.patch]

[jamie <jamiemcc blueyonder co uk>]

On Thu, 2007-03-01 at 23:53 +0100, Michael Biebl wrote:
> 2007/3/1, jamie <jamiemcc blueyonder co uk>:
> > -------- Forwarded Message --------
> > From: John Stowers <john stowers gmail com>
> > To: jamiemcc gnome org
> > Subject: libtracker-gtk.patch
> > Date: Fri, 2 Mar 2007 02:10:47 +1300
> >
> > Jamie,
> >
> > Here is the updated patch. Changes from the v2 version on the mailing
> > list
> [..]
>
> Hi Jamie,
>
> I've seen you merged the patch into svn.
> As we decided to make libtracker-gtk a requirement for t-s-t, I
> removed the #ifdefs from src/tracker-search-tool/* (patch attached)

oh yes - I almost forgot!

> There is also a minor correction to the header files installed by
> libtracker-gtk. (to use <tracker.h> instead of
> "../libtracker/tracker.h"). If the header files were only used
> internally, it wouldn't matter, but as they are installed system wide
> <tracker.h> is probably better ;-)

wont they fail on "make"?

you would need "make install" to install the headers system wide?

I would prefer to keep the headers as they are unless you are certain it
wont cause problems.

> Michael
>
> P.S.: Sorry for bringing this topic not up earlier, but  I would
> prefer if libtracker-gtk would have been called libtrackerui. This is
> mostly a matter of taste, but I think it is more consistent (to
> libtrackerclient, which does not use a "-" and to other gnome libs,
> like libbonobo/libbonoboui or libgnomeprint/libgnomeprintui).


not sure - I see libgnome-desktop in /usr/lib (as well as few others)

have applied and committed the rest - thanks

jamie.