Re: [Tracker] [PATCH] Potential crasher in set_language()



On Sun, 2007-07-22 at 23:21 +0200, Laurent Aguerreche wrote:
Hello,

a patch to fix a potential crasher in tracker_set_language() function :

- g_free() was called whether pointer to free could be NULL;
- we were mixing allocated strings and on-stack strings;
- added tracker_get_english_lang_code() function and put back tmap
implementation in tracker-utils.c (avoid warnings at building time)

+ cosmetic changes : I removed some empty lines for instance.


Can I commit?



ok for this one but no more cleanups pls until post 0.6 as I want to
release tomorrow

(I would prefer bugfixes to be separate from wide ranging cleanups if
possible)

thx







[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]