Hi there. Again, after looking over the code I found several things that could e 'trivially' fixed. * src/tracker-search-tool/tracker-search-tool.c:367 does a g_return_... if error != NULL - I am not sure if this behavior is correct, but it does prevent ugly 'false' snippets to be shown. * src/libtracker-gtk/tracker-utils.c:55 changed running indx to unsigned * src/libtracker/tracker.c:1338 changed a strstr to an strchr and casting to (const char**) (gcc42 warned me about this) * src/trackerd/tracker-db-sqlite.c :393 fixed false check, now this check is delegated to tracker_db_get_row :661 fixed a mem leak by removing yet another scope of char * sql :2214 fixed warning output that used an uninitialized variable :2806 shrinked scope of some variables (and fixed a small mem leak) :3271 fixed use of an uninitialized variable, replaced by immediate value of 0 * src/trackerd/tracker-indexer.c:572 fixed a false comparison * src/trackerd/tracker-utils.c:3177 did the highlighting as in the 'above' case Huh... was this too verbose?! I tested any change I made. Kind regards, Marcus
Attachment:
patch_smaller_fixes_20070716.diff
Description: Text Data