Re: [Tracker] [PATCH] Some smaller 'style' fixes and a missing g_free ()

From: jamie <jamiemcc blueyonder co uk>
To: Marcus Fritzsch <fritschy googlemail com>
Cc: Tracker List <tracker-list gnome org>
Subject: Re: [Tracker] [PATCH] Some smaller 'style' fixes and a missing g_free ()
Date: Sun, 15 Jul 2007 13:08:55 +0100

On Sun, 2007-07-15 at 00:43 +0200, Marcus Fritzsch wrote:

Hi,

i took a look over some code and changed some minor points - nothing grave ;)

One question: is g_return_... prefered for invalid input parameters,
or also for errors coming up within the function context? My current
setting is the first one ;) (see patch line 36 and 37)


yes g_return is preferred for invalid params as it should print the
error on the console and in xsession-errors

patch applied - thx

References:
- [Tracker] [PATCH] Some smaller 'style' fixes and a missing g_free ()
  - From: Marcus Fritzsch

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]