Re: [Tracker] t-s-t patch to remove gnome-open in favour of xdg-open

[Jamie McCracken <jamiemcc blueyonder co uk>]

Tshepang Lekhonkhobe wrote:
> On 1/11/07, Jamie McCracken <jamiemcc blueyonder co uk> wrote:
> > Deji Akingunola wrote:
> > > Hi,
> > >
> > > On 1/11/07, Tshepang Lekhonkhobe <tshepang gmail com> wrote:
> > >> Hi,
> > >>
> > >> Please review and comment if this patch is a good idea or not:
> > >> It removes the code for the fallback option of opening folders with
> > >> nautilus when xdg-utils is not installed. The consequence is that one
> > >> must have xdg-utils installed for this to work.
> > > What's the reasoning behind this? The fallback is good for folks
> > > without xdg-utils, for instance in Fedora, we don't have xdg-utils.
> > > Please drop this change.
> >
> > there is no runtime dependency on xdg-utils
> >
> > the patch falls back to gnome-open if the spawn of xdg-open fails so it
> > should be ok?
>
> The patch actually gets rid of the fallback and that's why Deji complains.

ahh yes (missed the minus on the open_with_nautilus line)

best play safe and keep both methods of opening

--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/