Re: [Tracker] [PATCH] Some work on tracker-preferences

[jamie <jamiemcc blueyonder co uk>]

On Mon, 2007-08-06 at 14:56 +0200, Laurent Aguerreche wrote:
> Hi,
>
>
> I send a patch for tracker-preferences :
>
>       * Adds copyright headers in tracker-preferences' files
>
> None source file has a copyright header... I set Jamie as author.

Saleem Abdulrasool <compnerd gentoo org> is the author - very little of
it is my code!




>       * Remove some code duplications in tracker-configuration.c
>
> I use some macros to avoid too many code duplications.
>
>       * Code cleanups in code of tracker-preferences
>
> There were useless g_slist_alloc() calls, and "int" or "char" instead of
> gint and gchar. Some g_slist_nth_data() too.
> "tmap" was declared as static but used as a global definition in
> tracker-configuration.h...
>
> For trackerd:
>     I added copyright headers in tracker-os-dependant* files + some
> cleanups.
>
>
> Since this code is rather trivial and that I tested it, can I commit?

sure looks ok at first glance