Re: [Tracker] couple of fixes

[Jamie McCracken <jamiemcc blueyonder co uk>]

Samuel Cormier-Iijima wrote:
> OK, I've split this up into two patches, and got rid of changing all
> of the tracker_logs to g_messages. So now, tracker_log is just a macro
> that expands to g_message. inotify.patch is the patch for numbers 1
> and 3. Cheers,

Okay the intoify patch is a bit tricky to review due to the complexity 
of the code. (I am a bit apprehensive about changing them as it can 
introduce new bugs and leaks)

I think the delete_watch leaks res object in your patch

I will look at it a bit more tomorrow but I may only accept part of your 
patch if thats okay with you.

The inotify move stuff is especially  complex but well tested and so I 
want to keep that bit as is. I will accept the rest though. (I hope you 
understand the time taking to review *and* test for bugs and leaks can 
be excessive especially with time in short supply)

In general can we hold off on *big* code cleanups until at least 
mid-october as I want to spend the time adding more important stuff.

Theres still plenty of stuff to fix in tracker that does not involve 
code cleanups like -

1) fix thumbnails to follow the freedesktop spec

2) support indexing of chat logs (this should be easy - just add source 
dirs to tracker struct like emails do)

3) support indexing of .desktop files (using GKeyFile this should be 
real easy too)

4) support indexing of tomboy notes

5) modify tracker-extract to use libvorbis/libid3tag/libexif/libgsf 
instead of libextractor for extracting embedded metadata (could also add 
support for writing this stuff too - just create  separate files for 
tracker-metadata-ogg.c , tracker-metadata-id3.c etc)




--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/