Re: [Tracker] patch to use GOption for tracker-search



On 9/17/06, Marcus Fritzsch <fritschy googlemail com> wrote:
Hi There,

On 9/17/06, Samuel Cormier-Iijima <sciyoshi gmail com> wrote:
> On 9/17/06, Jamie McCracken <jamiemcc blueyonder co uk> wrote:
> > Samuel Cormier-Iijima wrote:
> > > Here's another small patch for GOption support, this time in
> > > tracker-search. It also adds the option of limiting the number of
> > > results, makes use of g_strjoinv, and other small changes.
> > >
> >
> > great thanks - good work!
> >
> > Have now committed
> >
> > It would be nice to also add service option as well to tracker-search?
> >
> > EG tracker-search -s Music rock
>
> ok, i've added this. also, i made it do a synchronous call instead of async
>
> Samuel Cormier-Iijima

Nice work indeed ;) - but one thing, I think it would be better to
print a warning if the service is not recognised, that warning should
also mention that the service searched is Other Files - just a
usability thing I fellt over some time ago :)


Best regards, Marcus


Yea, actually I thought the same thing myself :-). Thanks though, and
update patch attached.

Samuel Cormier-Iijima

Attachment: tracker-search.patch
Description: Text Data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]