Re: [Tracker] Query with more than 3 metadata fields

[Jamie McCracken <jamiemcc blueyonder co uk>]

Samuel Cormier-Iijima wrote:
> Yes, it seems that the rdf query functionality is broken (the examples
> in CVS all seem to create bad SQL queries...) Anyways, the segfault
> was a glaring mistake, here's the patch.
>
> Samuel

> ------------------------------------------------------------------------
>
> Index: tracker-rdf-query.c
> ===================================================================
> RCS file: /cvs/gnome/tracker/src/trackerd/tracker-rdf-query.c,v
> retrieving revision 1.10
> diff -u -r1.10 tracker-rdf-query.c
> --- tracker-rdf-query.c 9 Sep 2006 23:54:08 -0000       1.10
> +++ tracker-rdf-query.c 15 Sep 2006 19:38:56 -0000
> @@ -391,14 +391,12 @@
>                 }
>         }
>  
> -	field_data = NULL;
> +       field_data = g_new0 (FieldData, 1);
>  
>  	if (!field_exists) {
>                 FieldDef *def;
>                 char     *istr;
>                 int      i;
> -
> -               field_data = g_new0 (FieldData, 1);
>  



field_data = NULL should be moved to top of function

if field_exists is true then we already have a field_data instance 
otherwise we create one so your patch is wrong I'm afraid

have fixed in cvs




--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/