Re: [Tracker] [Patch] New CVS version

[Laurent Aguerreche <laurent aguerreche free fr>]

Le vendredi 25 aoÃt 2006 Ã 13:34 +0100, Jamie McCracken a Ãcrit :
> Laurent Aguerreche wrote:
> > Small things:
> > - a typo in tracker_log()?
> >   "so now shuting" => "so now shutting"?

Yes, no? :-)


> sigfillset (&signal_set);
> sigprocmask (SIG_BLOCK, &signal_set, NULL);

sigprocmask() is only for single-threaded processes. Replace it with
pthread_sigmask().

> Ergo the only thread that can handle the signals in now the main thread.

I always wondered how masks on threads works and if it could make some
not-handled signals (i.e. user has to do many Ctrl+C to just see one
handled...). But I read some docs and it seems that only one thread with
a correct mask is needed. So it should work!

> I believe this should fix all outstanding issues and it should therefore 
> never crash or hang on exit.
>
> Please test latest CVS to confirm this is the case.

Ok, I just wanted to point the problem with sigprocmask().


Laurent.