Re: Patch: set of fixes for Bodystruct backend

[Sergio Villar Senin <svillar igalia com>]

Patch looks great at first sight. A couple of comments:

1) cachefile_get -> you have to free "filename" before assigning a new
value to it in the if block.
2) tny_camel_bs_mime_part_is_fetched -> you have to free "pos_filename"
before returning true

and a question

tny_camel_bs_msg_header_get_flags -> why always cached ?

Br

José Dapena Paz escribiu:
> 	Hi,
> 
> 	This patch is a set of fixes for bodystruct support in tinymail:
> 	* Enables bodystruct usage for IMAP by default.
> 	* Fixes charset handling for text/plain bodies in bodystruct backend.
> 	* Method tny_camel_bs_mime_part_is_fetched, to know if an specific mime
> part has been already retrieved.
> 	* Added global filter to bodystructure retrieve strategy, so that
> get_msg downloads not only the headers strutcture, but also the parts
> that we expect to be bodies.
> 	* Fixes in imap message cache reload
> 	* Fixed fetching the header (as it won't be a TnyCamelMsgHeader in some
> cases it was expected to be that).
> 	* Fix storing "allow external images" flag in bodystructure backend.
> 	* In bodystruct mime parts, "generate" some flags if the part is not
> retrieved. I.e., mime part size, so that we can offer this number even
> when the mime part is not fetched.
> 
> 	Though the patch is for modest-3-2 branch, I would ask for careful
> review, as the goal is having this both in tinymail trunk and our
> modest-3-2 branch.
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list