Re: Patch: Delay refresh on any get folders operation detected.



José Dapena Paz escribiu:
> El jue, 25-06-2009 a las 18:30 +0200, Sergio Villar Senin escribió:
> 
>> Dape regarding this subpatch:
>>
>> @@ -355,7 +372,7 @@ recurse_folders_async_cb (TnyFolderStore *store,
>>  			 * memory peak will happen, few data must be transmitted
>>  			 * in case we're online. Which is perfect! */
>>
>> -			if (folder)
>> +			if (folder && !(self->flags &
>> TNY_GTK_FOLDER_LIST_STORE_FLAG_DELAYED_REFRESH))
>>  				tny_folder_poke_status (TNY_FOLDER (folder));
>>
>> why are you removing the poke status if delayed refresh flag is used?
>> This way we won't get the right value for the unread/total amount of
>> messages.
> 
> 	I'm attaching a patch fixing this problem. This patch reenables
> poke_status calls but they're done in case of delayed refresh mode, in
> the delayed refresh.
> 
> Changelog entry:
> 
> 	* libtinymailui-gtk/tny-gtk-folder-list-store.c:
> 	reenable poke_status calls in delayed refresh mode.

I think you're forgetting to remove the extra reference you take when
creating the RefreshInfo structure


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]