Re: Patch: load summary on processing folder-tracking-changed



On Mon, 2009-07-27 at 18:27 +0200, José Dapena Paz wrote:
> El vie, 24-07-2009 a las 15:49 +0200, Philip Van Hoof escribió:
> > On Fri, 2009-07-24 at 15:38 +0200, José Dapena Paz wrote:
> > > -       if (!g_static_rec_mutex_trylock (priv->folder_lock)) {
> > > +       _tny_camel_folder_reason (priv);
> > > +       if (!load_folder_no_lock (priv)) {
> > >                 g_static_rec_mutex_unlock (priv->folder_lock);
> > >                 return;
> > >         }
> > 
> > 
> > You are not taking the folder_reason in case load_folder_no_lock failed.
> 
> 	I swear I didn't drunk on implementing the new patch.
> 
> 	Hope this time it's ok.


This looks better, yeah ;-)

Approved.

-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]